Skip to content

Travisbrown topic/dotty cross build#1

Closed
LukaJCB wants to merge 84 commits into
travisbrown:topic/dotty-cross-buildfrom
typelevel:travisbrown-topic/dotty-cross-build
Closed

Travisbrown topic/dotty cross build#1
LukaJCB wants to merge 84 commits into
travisbrown:topic/dotty-cross-buildfrom
typelevel:travisbrown-topic/dotty-cross-build

Conversation

@LukaJCB
Copy link
Copy Markdown

@LukaJCB LukaJCB commented May 21, 2020

No description provided.

PeterPerhac and others added 30 commits November 20, 2019 20:58
seems like someone re-implemented Option's `getOrElse` inside NonEmptyList. Delegate to Option#getOrElse instead
Use ArraySeq.untagged instead of ClassTag[Nothing]
* Add semiflatTap and leftSemiflatTap functions to EitherT

* Replaces Monad[F] with F
* Add semiflatTap and leftSemiflatTap functions to EitherT

* Replaces Monad[F] with F
* Update Scalafmt

* Don't remove newlines after e.g. forAll { (x: X) =>

* Format
scala-steward and others added 16 commits April 10, 2020 18:53
* Correct some mistakes in Comonad documentatoin

* Fix link in traverse doc
This TODO is solved by fixing issue #2514. 

It is added as a separate chapter, but could also be elided.
* Add foldF, cataF and emptyflatMap to OptionT

* Make emptyflatTap more tolerant on type

* Rename emptyflatTap to flatTapNone, fix docs

* Add tests for new OptionT methods

* Add OptionT.semiflatTap

* fix formatting in OptionTSuite

* Rename OptionT.flatTapNone's argument for clarity

Co-authored-by: Yannick Heiber <yannick.heiber@carjump.de>
Co-authored-by: Yannick Heiber <yannick.heiber@mobimeo.com>
@LukaJCB LukaJCB force-pushed the travisbrown-topic/dotty-cross-build branch from 372f037 to 059744c Compare May 21, 2020 02:36
@LukaJCB LukaJCB force-pushed the travisbrown-topic/dotty-cross-build branch from 059744c to 7fdb347 Compare May 21, 2020 02:43
@LukaJCB LukaJCB force-pushed the travisbrown-topic/dotty-cross-build branch from 98a0350 to a8fcdad Compare May 21, 2020 03:49
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #1 into topic/dotty-cross-build will not change coverage.
The diff coverage is n/a.

@@                   Coverage Diff                    @@
##           topic/dotty-cross-build       #1   +/-   ##
========================================================
  Coverage                    91.57%   91.57%           
========================================================
  Files                          379      379           
  Lines                         8201     8201           
  Branches                       235      235           
========================================================
  Hits                          7510     7510           
  Misses                         691      691           

@travisbrown
Copy link
Copy Markdown
Owner

@LukaJCB Do you mind if I rebase this branch manually to keep things clean and then cherry-pick your cats-free commit onto it?

@LukaJCB
Copy link
Copy Markdown
Author

LukaJCB commented May 21, 2020

Not at all

@LukaJCB
Copy link
Copy Markdown
Author

LukaJCB commented May 21, 2020

The merge wasn't entirely trivial, had to add a few things here and there just fyi

@travisbrown
Copy link
Copy Markdown
Owner

@LukaJCB Looking at this now, and I'm also going to rerun the Simulacrum Scalafix process, since there are some significant changes since this original experiment (like footers).

@LukaJCB
Copy link
Copy Markdown
Author

LukaJCB commented May 22, 2020

Oh cool, yeah I reran it to get the tests working since we've added methods to some typeclasses (like zipAll in align)

@travisbrown
Copy link
Copy Markdown
Owner

@LukaJCB 👍 I also just published a new release: https://github.com/typelevel/simulacrum-scalafix/releases/tag/v0.2.0

One annoying thing is that the footers cause "unmoored doc comment" warnings in Scaladoc because we have -Xlint enabled, but it seems reasonable to avoid that by disabling -Xlint in the (ScalaUnidoc, unidoc) scope.

I'm hoping to have the updated branch ready this afternoon.

@LukaJCB LukaJCB closed this Sep 9, 2020
@LukaJCB LukaJCB deleted the travisbrown-topic/dotty-cross-build branch September 9, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.