Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tdclient/bulk_import_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -101,14 +101,15 @@ def unfreeze(self):
self.update()
return response

def perform(self, wait=False, wait_interval=5, wait_callback=None):
def perform(self, wait=False, wait_interval=5, wait_callback=None, timeout=None):
"""Perform bulk import

Args:
wait (bool, optional): Flag for wait bulk import job. Default `False`
wait_interval (int, optional): wait interval in second. Default `5`.
wait_callback (callable, optional): A callable to be called on every tick of
wait interval.
timeout (int, optional): Timeout in seconds. No timeout by default.
"""
self.update()
if not self.upload_frozen:
Expand All @@ -117,7 +118,7 @@ def perform(self, wait=False, wait_interval=5, wait_callback=None):
)
job = self._client.perform_bulk_import(self.name)
if wait:
job.wait(wait_interval=wait_interval, wait_callback=wait_callback)
job.wait(timeout=timeout, wait_interval=wait_interval, wait_callback=wait_callback)
self.update()
return job

Expand Down
26 changes: 26 additions & 0 deletions tdclient/test/bulk_import_model_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,32 @@ def test_bulk_import_perfom():
assert bulk_import.update.called


def test_bulk_import_perform_with_timeout():
client = mock.MagicMock()
job_mock = mock.MagicMock()
client.perform_bulk_import.return_value = job_mock

bulk_import = models.BulkImport(
client,
name="name",
database="database",
table="table",
status="status",
upload_frozen=True,
job_id="job_id",
valid_records="valid_records",
error_records="error_records",
valid_parts="valid_parts",
error_parts="error_parts",
)
bulk_import.update = mock.MagicMock()
bulk_import.perform(wait=True, timeout=300, wait_interval=10)

client.perform_bulk_import.assert_called_with("name")
job_mock.wait.assert_called_with(timeout=300, wait_interval=10, wait_callback=None)
assert bulk_import.update.called


def test_bulk_import_commit():
client = mock.MagicMock()
bulk_import = models.BulkImport(
Expand Down
Loading