Skip to content

Avoid parsing assignment LHS as an expression list#83

Merged
maxbrunsfeld merged 4 commits into
masterfrom
identifier-reference
Sep 21, 2020
Merged

Avoid parsing assignment LHS as an expression list#83
maxbrunsfeld merged 4 commits into
masterfrom
identifier-reference

Conversation

@maxbrunsfeld
Copy link
Copy Markdown
Contributor

This will make it easier to distinguish variable definitions from variable references when consuming this syntax tree.

maxbrunsfeld and others added 2 commits September 21, 2020 12:59
Co-authored-by: Josh Vera <vera@github.com>
Co-authored-by: Ayman Nadeem <aymannadeem@github.com>
@maxbrunsfeld maxbrunsfeld merged commit 30f538a into master Sep 21, 2020
@maxbrunsfeld maxbrunsfeld deleted the identifier-reference branch September 21, 2020 20:21
theHamsta added a commit to theHamsta/nvim-treesitter that referenced this pull request Sep 21, 2020
theHamsta added a commit to theHamsta/nvim-treesitter that referenced this pull request Sep 21, 2020
vigoux pushed a commit to nvim-treesitter/nvim-treesitter that referenced this pull request Sep 21, 2020
@sencer
Copy link
Copy Markdown

sencer commented Sep 29, 2020

This commit causes the following error for me even in empty python files

Error detected while processing CursorHold Autocommands for "<buffer=1>":
E5108: Error executing lua /usr/local/share/nvim/runtime/lua/vim/treesitter/query.lua:20: query: invalid node type at position 1727

@stsewd
Copy link
Copy Markdown
Contributor

stsewd commented Sep 29, 2020

@sencer that is a problem from nvim-treesitter, not the grammar. And it was fixed in the plugin already.

@theHamsta
Copy link
Copy Markdown
Contributor

theHamsta commented Sep 29, 2020

@sencer that is a problem from nvim-treesitter, not the grammar. And it was fixed in the plugin already.

fixed by pinning to an older version of the parser. Updating to a 0.17.1 runtime in Neovim should fix the issue neovim/neovim#12931

@sencer
Copy link
Copy Markdown

sencer commented Sep 29, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants