Skip to content
This repository was archived by the owner on Feb 25, 2024. It is now read-only.

Conversation

@marcinkoziej
Copy link
Contributor

The code matched on [ _ | _ ] which assumes non-empty list, which would
fail for empty result from server (eg. Supabase.Storage.list("nonexistent"))

The code matched on [ _ | _ ] which assumes non-empty list, which would
fail for empty result from server (eg. `Supabase.Storage.list("nonexistent")`)
@marcinkoziej
Copy link
Contributor Author

Hi @treebee ! Could you please check out this simple fix?

@coveralls
Copy link

coveralls commented Aug 29, 2022

Pull Request Test Coverage Report for Build b28b983e8a0e414c7eaaf0f652426c8579263855-PR-3

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 92 unchanged lines in 7 files lost coverage.
  • Overall coverage decreased (-62.8%) to 12.162%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/supabase/connection.ex 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
lib/supabase/storage/bucket.ex 1 0.0%
lib/supabase/storage/object.ex 1 0.0%
lib/supabase.ex 7 27.27%
lib/supabase/storage/buckets.ex 8 11.11%
lib/supabase/storage.ex 16 3.85%
lib/supabase/connection.ex 29 18.6%
lib/supabase/storage/objects.ex 30 0.0%
Totals Coverage Status
Change from base Build 6333de7e367cdd74172f6bcdc5ce7c969556a5ad: -62.8%
Covered Lines: 18
Relevant Lines: 148

💛 - Coveralls

@treebee treebee merged commit cd7c065 into treebee:main Aug 29, 2022
@treebee
Copy link
Owner

treebee commented Aug 29, 2022

Thank you @marcinkoziej and sorry that it took so long. There's now a new release 0.2.3 with your fix. Thanks again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants