-
Notifications
You must be signed in to change notification settings - Fork 9
Add async library support #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve of the idea of adding async support! However, there are a few comments I left on your changes that I believe need to be addressed first.
|
Here. I did not remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good to me now! I'll let @LawMixer review it all too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, not unless @treeben77 wants to have a seperate pr for the formatting changes and all of that
Add async support on the entire library -- simply use
AsyncClientinstead ofClientif you want to work in an asyncronous environment.