Skip to content

Conversation

@Paillat-dev
Copy link
Contributor

Add async support on the entire library -- simply use AsyncClient instead of Client if you want to work in an asyncronous environment.

Copy link
Owner

@treeben77 treeben77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of the idea of adding async support! However, there are a few comments I left on your changes that I believe need to be addressed first.

@Paillat-dev Paillat-dev requested review from LawMixer and treeben77 July 5, 2024 14:00
@Paillat-dev
Copy link
Contributor Author

Here. I did not remove .idea/ from the .gitignore, it is from the JetBrains IDEs.

Copy link
Owner

@treeben77 treeben77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me now! I'll let @LawMixer review it all too.

Copy link

@LawMixer LawMixer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, not unless @treeben77 wants to have a seperate pr for the formatting changes and all of that

@treeben77 treeben77 merged commit 196d577 into treeben77:main Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants