Skip to content

Fix duplicate discriminator field in object variants#110

Merged
treeform merged 3 commits intomasterfrom
duplicate-discriminator
Mar 10, 2026
Merged

Fix duplicate discriminator field in object variants#110
treeform merged 3 commits intomasterfrom
duplicate-discriminator

Conversation

@treeform
Copy link
Owner

@treeform treeform commented Mar 10, 2026

Summary

  • Detect duplicate discriminator fields with conflicting values during JSON parsing of object variants.
  • In debug mode, catches Nim's FieldDefect; in release mode, compares the discriminator before and after parsing.
  • Both paths raise a clear JsonError instead of silently corrupting the variant.

Test plan

  • Added tests for both ValueNode and RefNode with conflicting duplicate discriminator JSON.

@treeform treeform merged commit fbbf55e into master Mar 10, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant