Add PPM format support#363
Conversation
|
Looks pretty good, thank you for the PR. can't wait for it to be finished. |
|
Thanks. This is the first time for me working on a "real" project in Nim, so any criticism is highly welcome. |
|
Does PPM support alpha? I think when writing out you need a convert image to straight alpha first? |
|
Good point, PPM does not support transparency or the alpha channel. I incorrectly did |
also fixes an issue with header decoder whitespace handling
|
Do you think its ready to go? Or are you still working on it? |
|
Functionality wise it's good to go, but I was wondering whether the code could be improved, but if you think it looks fine then it could be merged. |
|
Actually, scratch that, I've just found a bug in my implementation. |
|
Okay, I've fixed the bug and added a test case for it. When running tests, all of the produced images should be identical. I usually check manually by running |
|
I think you should assert. PPM has no compression so you can just have a master and check that the file bytes match. Then there is not need for manual check. |
This is a PR to add Netbpm's PPM format to Pixie. See issue #359 for more information on the format.
List of things to do: