Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
size-limit report 📦
|
e06a1d6 to
6c412b5
Compare
6c412b5 to
42ece5f
Compare
|
Also fixed the "with selected value" story |
42ece5f to
c581c62
Compare
lukasbals
left a comment
There was a problem hiding this comment.
I'm sorry to be so annoying - but this IMO doesn't fit into the select component. I would make this it's own component to keep the Select cleaner .... if we add properties like rangeFromLabel, ... it really doesn't make sense to have this as a variant of the select. Do you agree?
| const [value, setValue] = React.useState<string[]>(['', '']); | ||
| const [fromError, setFromError] = React.useState<string>(''); | ||
| const [toError, setToError] = React.useState<string>(''); |
There was a problem hiding this comment.
| const [value, setValue] = React.useState<string[]>(['', '']); | |
| const [fromError, setFromError] = React.useState<string>(''); | |
| const [toError, setToError] = React.useState<string>(''); | |
| const [value, setValue] = useState<string[]>(['', '']); | |
| const [fromError, setFromError] = useState<string>(''); | |
| const [toError, setToError] = useState<string>(''); |
Usually we import useState directly ...
c581c62 to
1318c50
Compare
1318c50 to
4f78adf
Compare
4f78adf to
aeb4cce
Compare
aeb4cce to
99f9537
Compare
99f9537 to
3372e0a
Compare
There was a problem hiding this comment.
Fixed the "with selected value" variant.
| @@ -0,0 +1,246 @@ | |||
| 'use client'; | |||
There was a problem hiding this comment.
Is this needed?
Does it make sense to have it if it's not Next.js app? (Boemly is no Next.js app)
There was a problem hiding this comment.
'use client' is a react directive
We need it in this component because with hooks we can't use SSR.
Chakra-UI documentation:
https://chakra-ui.com/docs/components/concepts/server-components
3372e0a to
42f6d49
Compare
|
🎉 This PR is included in version 10.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.