Conversation
86e1dc4 to
67e37eb
Compare
1 task
ab77ff4 to
54ec10a
Compare
Contributor
|
Contributor
|
Contributor
|
Contributor
|
Contributor
|
Contributor
|
06e2788 to
e27c10d
Compare
Contributor
|
Contributor
|
Contributor
Author
|
Ok, let's use it in master for now. There are a few todo's left, but the framework is working and showing the results for main commands, so we can already use for tracking regressions. Remotes and the rest of todos are coming in follow-ups. |
This was referenced Dec 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft
introduced benchmark categories:
api.open/read). Same reasoning as incli.commandscli.storiesbut for our api. E.g. imagine using our api with pandas or smth like that.migrated to pytest-benchmark
introduced creature comforts for developers:
--size(e.g.tiny(20),small(2K),large(70K), etc). All datasets are based on the same list of files and only differ by the number of files, to leverage deduplication and provide better performance.--remote(e.g.s3,azure, etc)pytestand get quick-ish results without having tribal knowledgedatasetandmake_datasetfixtures for quick test setupTODO:
generate html with histogramsgenerated html with CLI output, seems like it is enough for now and will not use much bandwith. Generated PR comments are a bit ugly, but fine for a POC.Related to resurrection epic #292