localfs: get_file: use exc-based dir handling #197
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
force-pushed
the
localfs-get_file
branch
from
a7970c3 to
9a6e935
Compare
Just to avoid wasting stat calls on every file we are copying.
efiop
force-pushed
the
localfs-get_file
branch
from
9a6e935 to
f7931c3
Compare
Contributor
Author
|
Looks like code in copyfile is not ready for that :( Looking into it... |
Codecov ReportBase: 64.54% // Head: 64.47% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
==========================================
- Coverage 64.54% 64.47% -0.07%
==========================================
Files 25 25
Lines 1918 1920 +2
Branches 299 299
==========================================
Hits 1238 1238
- Misses 626 628 +2
Partials 54 54
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Collaborator
|
Closing. Thanks @efiop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to avoid wasting stat calls on every file we are copying.