Skip to content

localfs: get_file: use exc-based dir handling #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

localfs: get_file: use exc-based dir handling #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/dvc_objects/fs/local.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,12 +97,14 @@ def put_file(self, lpath, rpath, callback=None, **kwargs):
os.replace(tmp_file, rpath)

def get_file(self, rpath, lpath, callback=None, **kwargs):
if self.isdir(rpath):
# emulating fsspec's localfs.get_file
self.makedirs(lpath, exist_ok=True)
return

copyfile(rpath, lpath, callback=callback)
try:
copyfile(rpath, lpath, callback=callback)
except IsADirectoryError:
if self.isdir(rpath):
# emulating fsspec's localfs.get_file
self.makedirs(lpath, exist_ok=True)
else:
raise

def mv(self, path1, path2, **kwargs):
self.makedirs(self._parent(path2), exist_ok=True)
Expand Down