-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Description
To reproduce:
mkdir test-import-ui
git init
dvc init
dvc import https://github.com/iterative/example-get-started data/features
While it's running:
Multi-Threaded: is blinking multiple times (cc @casperdcl ).
Importing 'data/features (https://github.com/iterative/example-get-started)' -> 'features'
Multi-Threaded:
49%|████▉ |../../../../private/var/folders/_1/dxrf7_f15sn4r01jvqvr5b6h0000gn/T/tmp64drrk0idvc-erepo/data/features/train.pkl 5636096/11549662 [00:08<00:15, 374kB/s]
If we have a few separate steps (querying something, calculating checksums, downloading, etc) - it would be helpful to show clearly the message of what's happening. It might be helpful to see that this stage is done, instead of just removing everything. Otherwise it's all blinking too fast.
We must avoid exposing temp path (handled in #2605).
When it's done:
Importing 'data/features (https://github.com/iterative/example-get-started)' -> 'features'
Output 'features' didn't change. Skipping saving.
To track the changes with git, run:
git add .gitignore features.dvc
Output 'features' didn't change. Skipping saving. - what does it mean? Is it done successfully? What has just happened?
Todo here or use multiple PRs:
- Make sure that
Multi-Threadedis not used anymore - Add a meaningful message around progress bar that clarifies what's going on here (calculating hashes, downloading data, etc)
-
Do not use temp file paths(handled separately in dvc get/import shows temporary paths #2605 per @Suor comment below) - Remove
skipping savingmessage at the end. Make sure we don't break any other commands. - (discuss) Show some meaningful message at the end.