fix(plots): handle empty directories #10344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
reviewed
Mar 7, 2024
skshetry
reviewed
Mar 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10344 +/- ##
==========================================
- Coverage 90.64% 90.42% -0.22%
==========================================
Files 500 500
Lines 38641 38650 +9
Branches 5586 5587 +1
==========================================
- Hits 35027 34951 -76
- Misses 2969 3035 +66
- Partials 645 664 +19 ☔ View full report in Codecov by Sentry. |
Co-authored-by: skshetry <18718008+skshetry@users.noreply.github.com>
skshetry
approved these changes
Mar 7, 2024
BradyJ27
pushed a commit
to BradyJ27/dvc
that referenced
this pull request
Apr 22, 2024
* fix(plots): handle empty directories * Update tests/integration/plots/test_plots.py Co-authored-by: skshetry <18718008+skshetry@users.noreply.github.com> * cleanup after review --------- Co-authored-by: skshetry <18718008+skshetry@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression after #10320 that hits us in Studio parser in some repos (we are getting Sentry alerts).
I see also a few other potential issues / regressions - will add small PRs to address them as well.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏