pipeline show add --dot option #1141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
suggested changes
Sep 20, 2018
Contributor
efiop
left a comment
efiop
left a comment
There was a problem hiding this comment.
Thank you for the PR! Looks very good! A few comments below:
dvc/cli.py
Outdated
| help='Output DAG as ASCII.') | ||
| pipeline_show_parser.add_argument( | ||
| '--dot', | ||
| dest='filename', |
Contributor
There was a problem hiding this comment.
You don't need the dest argument. Without it by default it is going to be dest='dot' which a more suitable name for this.
Contributor
|
Ah, one more thing. Tests seem to fail mainly because there is no |
Contributor
Author
|
flake8 fails again and again on line that seems ok to me, my own installation does not show any problems, is there some special config for flake8 on travis? |
Contributor
|
Looks good! Merged. Thank you! |
efiop
approved these changes
Sep 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please take closer look on add_argument, I am not quite sure if i got this right.