install: verify no hooks colliding with dvc exist #2505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
reviewed
Sep 17, 2019
tests/func/test_install.py
Outdated
|
|
||
| assert main(["install"]) != 0 | ||
|
|
||
| @pytest.mark.skip(reason="https://github.com/iterative/dvc/issues/2362") |
Contributor
There was a problem hiding this comment.
Leftover from WIP? These tests should be removed now, right?
Contributor
Author
There was a problem hiding this comment.
Well, to be honest looking at #2362 I though that this change is first step to handle hooks more gracefully. I though that we might want to get back to this tests at some point, and thats why I thought leaving them around might be a good think. What do you think?
Contributor
There was a problem hiding this comment.
@pared No need to keep unused code, we can bring this back later if we need to without any problems.
efiop
reviewed
Sep 18, 2019
Co-Authored-By: Ruslan Kuprieiev <kupruser@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have you followed the guidelines in our
Contributing document?
Does your PR affect documented changes or does it add new functionality
that should be documented? If yes, have you created a PR for
dvc.org documenting it or at
least opened an issue for it? If so, please add a link to it.
Fixes #2362