Skip to content

sort dvc pipeline list output #2588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

sort dvc pipeline list output #2588

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dvc/command/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ def run(self):
pipelines = self.repo.pipelines
for p in pipelines:
stages = networkx.get_node_attributes(p, "stage")
for stage in stages:
for stage in sorted(stages):
Copy link
Contributor

@efiop efiop Oct 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, this is not the way to solve the original issue. You are sorting alphabetically, but the original issue is about sorting in the order of execution, basically the way dvc repro does it. See https://github.com/iterative/dvc/blob/0.62.0/dvc/repo/reproduce.py#L172 . So what we need to do here is to print them in the order of dfs_postorder, same as it is in the dvc repro's usual way of execution.

logger.info(stage)
if len(stages) != 0:
logger.info("=" * 80)
Expand Down