Skip to content

fix PR template to mention recommendatory nature of CC and DS #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 4, 2019
Merged

fix PR template to mention recommendatory nature of CC and DS #2723

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d0e62a5
fix PR template to mention recommendatory nature of CC and DS
shcheklein Nov 3, 2019
60bdd41
PR template: address review, update DS and CC checks item
shcheklein Nov 4, 2019
8b05eb5
PR template: minor sentence with emoji style change
shcheklein Nov 4, 2019
cbb58e0
PR template: change wording for the docs checkbox
shcheklein Nov 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,19 @@
* [ ] Have you followed the guidelines in our
[Contributing document](https://dvc.org/doc/user-guide/contributing/core)?
* [ ] ❗ Have you followed the guidelines in the
[Contributing to DVC](https://dvc.org/doc/user-guide/contributing/core)
list?

* [ ] Does your PR affect documented changes or does it add new functionality
that should be documented? If yes, have you created a PR for
[dvc.org](https://github.com/iterative/dvc.org) documenting it or at
least opened an issue for it? If so, please add a link to it.
* [ ] 📖 Check this box if this PR **does not** require
[documentation](https://dvc.org/doc) updates, or if it does **and** you
have created a separate PR in
[dvc.org](https://github.com/iterative/dvc.org)
with such updates (or at least opened an issue about it in that repo).
Please link below to your PR (or issue) in the
[dvc.org](https://github.com/iterative/dvc.org) repo.

* [ ] ❌ Have you checked DeepSource, CodeClimate, and other sanity checks
below? We consider their findings recommendatory and don't expect
everything to be addresses. Please review them carefully and fix those
that actually improve code or fix bugs.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

-----