Skip to content

update py3.7 => py3.8 #2912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

update py3.7 => py3.8 #2912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
stage: check
os: linux
language: python
python: 3.7
python: 3.8
Copy link
Contributor

@efiop efiop Dec 6, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't replace it, but rather be a new addition. Same with stuff down below.

Copy link
Contributor

@efiop efiop Dec 6, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or was it just a test?

In any case, we've had some issues with conda packages on 3.8, so probably not all dependencies are ready yet. I would wait until all our deps support 3.8.

Copy link
Contributor Author

@casperdcl casperdcl Dec 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a draft, py3.8 has been officially released so should be mergeable soon

Copy link
Contributor Author

@casperdcl casperdcl Dec 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like the main blocker is cython even though it installs in a local py38 env... have you made a start on debugging these issues in another PR @efiop?

Copy link
Contributor

@efiop efiop Dec 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@casperdcl Not really, 38 is not that urgent :) I would just wait a bit until everything settles in other projects. E.g. https://pypi.org/project/pyarrow/#files still doesn't have 3.8 wheels. I imagine 3.8 will settle down in Jan or something.

Copy link
Contributor

@efiop efiop Dec 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Def wouldn't spend time on it for now.

before_install:
install:
script: ./scripts/ci/check_patch.sh
Expand All @@ -41,7 +41,7 @@ jobs:
language: shell # 'language: python' is an error on Travis CI Windows
env:
- PY2=1
- name: "3.7 on Windows"
- name: "3.8 on Windows"
os: windows # Windows 10.0.17134 N/A Build 17134
language: shell # 'language: python' is an error on Travis CI Windows
- name: "2.7 on Linux"
Expand All @@ -55,9 +55,9 @@ jobs:
- name: "3.6 on Linux"
language: python
python: 3.6
- name: "3.7 on Linux"
- name: "3.8 on Linux"
language: python
python: 3.7
python: 3.8
- name: "2.7 on Mac"
os: osx
osx_image: xcode9.4
Expand All @@ -82,13 +82,13 @@ jobs:
script: ./scripts/build_windows.cmd
- name: "Linux pkgs"
language: python
python: 3.7
python: 3.8
before_install:
install:
script: ./scripts/build_posix.sh
- name: "Pypi pkgs"
language: python
python: 3.7
python: 3.8
script: ./scripts/build_package.sh
- name: Snapcraft snap
addons:
Expand All @@ -114,7 +114,7 @@ jobs:
if: tag is present
stage: deploy
language: python
python: 3.7
python: 3.8
script: ./scripts/build_package.sh
deploy:
- provider: pypi
Expand Down
4 changes: 2 additions & 2 deletions scripts/ci/before_install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ if [[ "$TRAVIS_OS_NAME" == "windows" ]]; then
choco install python2
echo 'PATH="/c/Python27:/c/Python27/Scripts:$PATH"' >> env.sh
else
choco install python --version 3.7.5
echo 'PATH="/c/Python37:/c/Python37/Scripts:$PATH"' >> env.sh
choco install python --version 3.8.0
echo 'PATH="/c/Python38:/c/Python38/Scripts:$PATH"' >> env.sh
fi
elif [[ "$TRAVIS_OS_NAME" == "osx" ]]; then
if [[ ! -n "$PY2" ]]; then
Expand Down
1 change: 1 addition & 0 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ def run(self):
"Programming Language :: Python :: 3.5",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
],
packages=find_packages(exclude=["tests"]),
include_package_data=True,
Expand Down