api: identify local repos with os.path.exists

[ghost]

Close #3111

[ghost]

I'm using a solution suggested by @efiop , which identifies local repositories by checking if they are in the file system. There's no way a URL (e.g. https://, git@github) could be missed like that.

I'm not aware of any other edge case.

[ghost]

Probably, file:// but no one uses it 😅

[efiop]

Yeah, we don't support file:// anywhere else, so no need to worry about it for now. Neither any user asked for it ever 🙂

[efiop]

Possibly could use a test, but this solution so neat and trivial that it doesn't require it 👍

[skshetry]

It'd be good to have a regression test so that ssh URLs don't get broken later on? 🙂

Not related to this change though, but regarding the issue. Thoughts?

[ghost]

sure, @skshetry , didn't know how to test it properly, to be honest 😅

Any ideas? Do you want to send the pull request?

[efiop]

@skshetry The exists works pretty good there, as we don't mess with urls at all. Whatever we have - we just pass it to git to deal with it. You mean something like a mock test that would ensure that ssh-like git url would be passed to _make_repo instead of only to Repo()?