Skip to content

minor comments #3173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2020
Merged

minor comments #3173

merged 1 commit into from
Jan 16, 2020

Conversation

@casperdcl
Copy link
Contributor

@casperdcl casperdcl commented Jan 16, 2020 •
edited
Loading

@casperdcl
minor comments
d34aa44 
- explains review concerns in treeverse#3158
@casperdcl casperdcl requested a review from efiop January 16, 2020 20:39
@casperdcl casperdcl self-assigned this Jan 16, 2020
@casperdcl casperdcl mentioned this pull request Jan 16, 2020
Merged
5 tasks
@efiop efiop merged commit 422ff57 into treeverse:master Jan 16, 2020
@efiop
Copy link
Contributor

efiop commented Jan 16, 2020

Thanks!

@casperdcl casperdcl deleted the snap-deploy branch January 19, 2020 18:16
This was referenced Jan 21, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efiop efiop Awaiting requested review from efiop

Assignees

@casperdcl casperdcl

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@casperdcl @efiop