template: pr update #3495
Merged
template: pr update #3495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shcheklein
approved these changes
Mar 17, 2020
Contributor
jorgeorpinel
left a comment
jorgeorpinel
left a comment
There was a problem hiding this comment.
I'm taking the liberty to commit these suggestions but feel free to review them, thanks.
jorgeorpinel
approved these changes
Mar 17, 2020
Contributor
|
I'm not sure this totally fixes #2985 though, have we also checked that the completion scripts currently match the help output? 🙂 |
Contributor
Author
|
No, not fully sure it completely fixes #2985 (I have updated bash completion a lot in a few PRs though so it's likely reasonably up-to-date). I think #2985 is as fixed as it's going to get without automating creation of completion scripts so probably best to close. Could open a new issue about automating? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update PR template to be more succinct; add note about completion scripts.
Fixes? #2985