Skip to content

Conversation

@efiop
Copy link
Contributor

@efiop efiop commented Jun 2, 2020

  • ❗ I have followed the Contributing to DVC checklist.

  • 📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

@efiop efiop changed the title debug gdrive [WIP] debug gdrive Jun 2, 2020
@efiop efiop force-pushed the gdrive-test branch 2 times, most recently from 9d9f72e to d7c9d0c Compare June 3, 2020 00:25
@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #3941 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3941      +/-   ##
==========================================
- Coverage   92.15%   92.14%   -0.01%     
==========================================
  Files         161      161              
  Lines       11180    11180              
==========================================
- Hits        10303    10302       -1     
- Misses        877      878       +1     
Impacted Files Coverage Δ
dvc/version.py 83.33% <0.00%> (-2.78%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3590fe8...7528ee1. Read the comment docs.

@restyled-io restyled-io bot mentioned this pull request Jun 3, 2020
@efiop efiop force-pushed the gdrive-test branch 4 times, most recently from 031efc8 to a4c0bf8 Compare June 3, 2020 04:49
@efiop efiop changed the title [WIP] debug gdrive tests: gdrive: don't cache url Jun 3, 2020
This makes `GDrive.get_url` behaviour consistent with the rest of the
test remotes.

Related to #3916
@efiop efiop merged commit a65c798 into master Jun 4, 2020
@efiop efiop deleted the gdrive-test branch June 4, 2020 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant