Skip to content

Conversation

@efiop
Copy link
Contributor

@efiop efiop commented Jun 8, 2020

Per #3911 (comment) and #3948

  • ❗ I have followed the Contributing to DVC checklist.

  • πŸ“– If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here. If the CLI API is changed, I have updated tab completion scripts.

  • ❌ I will check DeepSource, CodeClimate, and other sanity checks below. (We consider them recommendatory and don't expect everything to be addressed. Please fix things that actually improve code or fix bugs.)

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

@efiop efiop force-pushed the fix-3911 branch 2 times, most recently from ca93d14 to 5307440 Compare June 8, 2020 23:09
@efiop
Copy link
Contributor Author

efiop commented Jun 8, 2020

For the record: discussing --template metavar in https://github.com/iterative/dvc.org/pull/1382/files#r437050234

@efiop efiop self-assigned this Jun 8, 2020
@efiop efiop added enhancement Enhances DVC ui user interface / interaction labels Jun 8, 2020
@efiop efiop merged commit 5be12b5 into treeverse:master Jun 9, 2020
@efiop efiop deleted the fix-3911 branch June 9, 2020 11:33
@jorgeorpinel
Copy link
Contributor

Thanks for the responsiveness in all these guys. Sorry I could't look while it was in progress β€” dealing with the docs in parallel πŸ˜‹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhances DVC ui user interface / interaction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants