Skip to content

Conversation

@casperdcl
Copy link
Contributor

@casperdcl casperdcl commented Jun 9, 2020

@casperdcl casperdcl self-assigned this Jun 9, 2020
@casperdcl casperdcl requested a review from efiop June 9, 2020 09:58
@casperdcl casperdcl added bug Did we break something? build labels Jun 9, 2020
@casperdcl
Copy link
Contributor Author

casperdcl commented Jun 9, 2020

Hmm Travis has a radically different guide suggesting docker, which concludes on the next page to check out cmake, which amusingly has moved on to a different approach identical to what we use here. As of 2 hours ago a minor fix was pushed (Crascit/cmake-snap@7ee6e17) to fix the sudo issue.

Let's just say nothing is documented anywhere.

@casperdcl casperdcl changed the title snap: drop sudo snap: build fixes Jun 9, 2020
@casperdcl casperdcl marked this pull request as ready for review June 9, 2020 20:44
@casperdcl
Copy link
Contributor Author

@efiop ready for merge

@efiop
Copy link
Contributor

efiop commented Jun 9, 2020

Thank you @casperdcl ! 🙏

@efiop efiop merged commit 5efc3bb into treeverse:master Jun 9, 2020
casperdcl added a commit to casperdcl/dvc that referenced this pull request Jun 9, 2020
@casperdcl casperdcl mentioned this pull request Jun 9, 2020
6 tasks
efiop pushed a commit that referenced this pull request Jun 13, 2020
* snap: drop sudo

Fixes #3989

* snap: ci: fix builds

* snap: ci: developer notifications

* snap: minimise size

* debug commit

* Revert "snap: minimise size"

This reverts commit 77b41a9.

* fix image info

* Revert "debug commit"

This reverts commit 232baf0.

* snap: v1 channels

Related: #3872

* snap: v0 channels

Related #3990
Related #3989

* snap: auto-version (major) detect

* ci: fetch --tags explanation & error checking

* snap: update warning framework

* hardocde warning

* add deprecation dev comment

* remove warning on explicit v0 channel

* tidy comment

* fix py2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Did we break something?

Projects

None yet

Development

Successfully merging this pull request may close these issues.

snap: 'sudo' cannot be used with build provider 'lxd'

2 participants