[WIP] RepoTree: alternate design #4387
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skshetry
commented
Aug 13, 2020
Comment on lines
+79
to
+80
| t = tree._get_tree( # pylint: disable=protected-access | ||
| info |
Collaborator
Author
There was a problem hiding this comment.
This is of-course going to be fixed by stats() as I said in other PR.
Contributor
|
No longer relevant, since #4381 is merged. |
Collaborator
Author
|
@efiop, I thought you'd like this? Anyway, thanks for merging. :) |
Contributor
|
@skshetry I like it, but the other PR is more wholesome :) I think we'll definitely introduce some good ideas from this PR in the upcoming changes 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Yet Another Tree Abstraction 😢