Skip to content

tree: http: try GET on failed HEAD #4390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
efiop merged 1 commit into from
Aug 18, 2020
Merged

tree: http: try GET on failed HEAD #4390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions dvc/tree/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,12 +122,27 @@ def request(self, method, url, **kwargs):
except requests.exceptions.RequestException:
raise DvcException(f"could not perform a {method} request")

def _head(self, url):
response = self.request("HEAD", url)
if response.ok:
return response

# Sometimes servers are configured to forbid HEAD requests
# Context: https://github.com/iterative/dvc/issues/4131
with self.request("GET", url, stream=True) as r:
if r.ok:
return r

return response

def exists(self, path_info, use_dvcignore=True):
return bool(self.request("HEAD", path_info.url))
return bool(self._head(path_info.url))

def get_file_hash(self, path_info):
url = path_info.url
headers = self.request("HEAD", url).headers

headers = self._head(url).headers

etag = headers.get("ETag") or headers.get("Content-MD5")

if not etag:
Expand Down