utils/fs: checking files ownership in 'move' (#4348) #4832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pared
reviewed
Nov 4, 2020
Exception is verbose enough.
pared
approved these changes
Nov 6, 2020
Contributor
pared
left a comment
pared
left a comment
There was a problem hiding this comment.
Looks great! One minor thing
pared
suggested changes
Nov 6, 2020
If error related to access/permission, throw the newly created FileOwnershipError exception, otherwise throw the OSError as is.
pared
approved these changes
Nov 9, 2020
Contributor
|
@danielfleischer looks good, the tests |
Using the function _unlink which includes error handling.
Author
|
Made a small fix; used |
pared
approved these changes
Nov 11, 2020
skshetry
approved these changes
Nov 12, 2020
Contributor
|
@danielfleischer Thank you very much! |
This was referenced Nov 12, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Files are checked for ownership by trying to
chmodthem before moving them around; if fail, return a verbose exception.Previous behavior: moving files to a temp folder and then do the check; when fail, files seemed to be missing.
Should fix #4348 and maybe fix #2992.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏