dvc: refactor cache/remote relations #4867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efiop
commented
Nov 10, 2020
efiop
commented
Nov 10, 2020
efiop
commented
Nov 10, 2020
efiop
commented
Nov 10, 2020
efiop
commented
Nov 10, 2020
efiop
commented
Nov 10, 2020
dvc/cache/base.py
Outdated
Contributor
Author
There was a problem hiding this comment.
Previosly we checked the index here, but that was mixing up remotes and caches, which is incorrect, so now we first check the index in Remote(because our current indexes are local indexes for remote caches) and then fallback to checking cache, which is naturual and provides nice intuitive isolation.
efiop
commented
Nov 10, 2020
efiop
commented
Nov 10, 2020
dvc/remote/__init__.py
Outdated
Comment on lines
-11
to
-12
Contributor
Author
There was a problem hiding this comment.
We never needed an SSHRemote, as all of the custom stuff was actually about SSHCache.
efiop
commented
Nov 10, 2020
efiop
commented
Nov 10, 2020
dvc/remote/base.py
Outdated
Contributor
Author
There was a problem hiding this comment.
This conversion that we do might be causing things like #4139 . Might want to check.
efiop
commented
Nov 10, 2020
efiop
changed the title
I159
added a commit
to I159/dvc
that referenced
this pull request
Nov 10, 2020
…limit * 'master' of github.com:iterative/dvc: dvc: refactor cache/remote relations (treeverse#4867) codecov: add target coverage, and threshold for patch and project (treeverse#4873)
skshetry
added
refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The final separation that puts this Cache/Remote/Tree trio in their proper places.
No new logic added, just tossing around methods to make them lend in logical places (except for minor gc message adjustments and new internal helpers). E.g. index is for Remote, but listing the cache is for Cache.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏