Skip to content

repro: remove deprecated --cwd #5048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2020
Merged

repro: remove deprecated --cwd #5048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions dvc/command/experiments.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import argparse
import io
import logging
import os
from collections import OrderedDict
from collections.abc import Mapping
from datetime import date, datetime
Expand Down Expand Up @@ -438,10 +437,6 @@ def run(self):

class CmdExperimentsRun(CmdRepro):
def run(self):

saved_dir = os.path.realpath(os.curdir)
os.chdir(self.args.cwd)

# Dirty hack so the for loop below can at least enter once
if self.args.all_pipelines:
self.args.targets = [None]
Expand All @@ -466,7 +461,6 @@ def run(self):
ret = 1
break

os.chdir(saved_dir)
return ret


Expand Down
13 changes: 0 additions & 13 deletions dvc/command/repro.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import argparse
import logging
import os

from dvc.command import completion
from dvc.command.base import CmdBase, append_doc_link
Expand All @@ -14,9 +13,6 @@

class CmdRepro(CmdBase):
def run(self):
saved_dir = os.path.realpath(os.curdir)
os.chdir(self.args.cwd)

# Dirty hack so the for loop below can at least enter once
if self.args.all_pipelines:
self.args.targets = [None]
Expand Down Expand Up @@ -45,7 +41,6 @@ def run(self):
ret = 1
break

os.chdir(saved_dir)
return ret

@property
Expand Down Expand Up @@ -88,14 +83,6 @@ def add_arguments(repro_parser):
help="Reproduce only single data item without recursive dependencies "
"check.",
)
repro_parser.add_argument(
"-c",
"--cwd",
default=os.path.curdir,
help="Directory within your repo to reproduce from. Note: deprecated "
"by `dvc --cd <path>`.",
metavar="<path>",
)
repro_parser.add_argument(
"-m",
"--metrics",
Expand Down
39 changes: 0 additions & 39 deletions tests/func/test_repro.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,45 +781,6 @@ def test(self):
self.assertNotEqual(ret, 0)


class TestCmdReproChdir(TestDvc):
def test(self):
dname = "dir"
os.mkdir(dname)
foo = os.path.join(dname, self.FOO)
bar = os.path.join(dname, self.BAR)
code = os.path.join(dname, self.CODE)
shutil.copyfile(self.FOO, foo)
shutil.copyfile(self.CODE, code)

ret = main(
[
"run",
"--single-stage",
"--file",
f"{dname}/Dvcfile",
"-w",
f"{dname}",
"-d",
self.FOO,
"-o",
self.BAR,
f"python {self.CODE} {self.FOO} {self.BAR}",
]
)
self.assertEqual(ret, 0)
self.assertTrue(os.path.isfile(foo))
self.assertTrue(os.path.isfile(bar))
self.assertTrue(filecmp.cmp(foo, bar, shallow=False))

os.unlink(bar)

ret = main(["repro", "-c", dname, DVC_FILE])
self.assertEqual(ret, 0)
self.assertTrue(os.path.isfile(foo))
self.assertTrue(os.path.isfile(bar))
self.assertTrue(filecmp.cmp(foo, bar, shallow=False))


class TestReproShell(TestDvc):
def test(self):
if os.name == "nt":
Expand Down