Skip to content

Conversation

@pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Mar 11, 2021

Thank you for the contribution - we'll try to review it as soon as possible. πŸ™

Related to #5593

If the result of exp run is identical to the parent commit (HEAD), do nothing. Previously, for --temp runs we would do nothing, but workspace runs would generate an empty named experiment which was identical to HEAD.

@skshetry
Copy link
Collaborator

@pmrowla, does this also solve #5567?

@pmrowla
Copy link
Contributor Author

pmrowla commented Mar 11, 2021

@skshetry possibly? There was a bug with workspace runs where the workspace was considered dirty because of the way we pass repro args into the experiment (even though the end result would still be an empty git commit) that should be resolved by this PR.

That may be what was causing the "conflicts with existing experiment" issue you were seeing in that issue

@skshetry

This comment has been minimized.

@mergify

This comment has been minimized.

@efiop efiop force-pushed the exp-run-unchanged-workspace branch from c81b6b4 to 775bcb5 Compare March 11, 2021 10:10
@skshetry
Copy link
Collaborator

skshetry commented Mar 11, 2021

@skshetry possibly?

Looks like not.

cd "$(mktemp -d)" && git init && dvc init
dvc stage add -n echo -p foo -m metrics.yaml "echo params.yaml > metrics.yaml"
echo "foo: 10" > params.yaml
git add -A && git commit -m "initialize"
dvc exp run
dvc exp run

@pmrowla pmrowla merged commit fe4cb9c into treeverse:master Mar 12, 2021
@pmrowla pmrowla deleted the exp-run-unchanged-workspace branch March 12, 2021 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix fixes bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants