ssh: don't use path_info for connections #6259
Conversation
| self.password = ask_password(self.host, self.user, self.port) | ||
|
|
||
| def ssh(self, path_info): | ||
| def ssh(self): |
There was a problem hiding this comment.
One issue that arises here is that move() in ObjectDB.add() will no longer work for advanced cases where a user has external-outputs with external cache that is not located on the same filesystem. This very rare though and has been a common problem for other filesystems too in external-output scenario anyway, so I woundn't fix it right now, as that is a hack already that we are keeping https://github.com/iterative/dvc/blob/master/dvc/objects/db/base.py#L78 for regular non-extrnal dvc add and such. We will be adjusting that in save/transfer unification anyway.
There was a problem hiding this comment.
Also, now that this doesn't take any arguments, we could adjust the way it looks and works, but again I would just wait for sshfs migration, since it will simply throw away this code anyway, so doesn't seem like it is worth wasting time refactoring this now.
efiop
changed the title
1 participant
Fixes #6225
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏