Skip to content

fs: s3: don't forget to pass verify option#6298

Merged
skshetry merged 2 commits into
treeverse:masterfrom
kareemjano:patch-1
Jul 8, 2021
Merged

fs: s3: don't forget to pass verify option#6298
skshetry merged 2 commits into
treeverse:masterfrom
kareemjano:patch-1

Conversation

@kareemjano
Copy link
Copy Markdown
Contributor

@kareemjano kareemjano commented Jul 8, 2021

S3: SSL Certificate Error

Fixes #5972 .

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

pass verify flag when creating a session
@kareemjano kareemjano requested a review from a team as a code owner July 8, 2021 13:38
@kareemjano kareemjano requested a review from isidentical July 8, 2021 13:38
@efiop efiop changed the title (bugfix) Update s3.py fs: s3: don't forget to pass verify option Jul 8, 2021
Copy link
Copy Markdown
Collaborator

@skshetry skshetry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @kareemjano for the speedy contributions. Appreciated. 🙂

@skshetry skshetry merged commit 22781f5 into treeverse:master Jul 8, 2021
@efiop efiop added the bugfix fixes bug label Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix fixes bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dvc push: unable to validate self-signed certificate from S3 service

3 participants