exp remove: refactor exp utils #7205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
pmrowla
suggested changes
Jan 5, 2022
pmrowla
approved these changes
Jan 5, 2022
fix: treeverse#7196 1. Refactor exp_ref_by_name in `dvc/repo/experiments/utils.py`. In previous the exp_ref_by_name walk throught all of the references to match only one exp name. This makes multi exp name seeking to be a job of `O(mn)` complexity, Walking though the exp ref and return all of the exp ref with greatly reduce this complexity to `O(n)` Co-authored-by: Peter Rowlands (변기호) <peter@pmrowla.com>
karajan1001
force-pushed
the
refactor_exp_utils
branch
from
3f1138c to
73ba298
Compare
karajan1001
added
refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7196
Refactor exp_ref_by_name in
dvc/repo/experiments/utils.py.In previous the exp_ref_by_name walk throught all of the references to
match only one exp name. This makes multi exp name seeking to be a job
of
O(mn)complexity, Walking though the exp ref and return all of theexp ref with greatly reduce this complexity to
O(n)❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏