exp: implement internal queue.kill support(#7587) #7714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karajan1001
commented
May 9, 2022
| test_queue.kill("bar") | ||
|
|
||
| while True: | ||
| if result_foo.status == "SUCCESS": |
Contributor
Author
There was a problem hiding this comment.
Here, even if we killed the process "bar", the result_bar.status still returns "SUCCESS", only celery.control.revoke would make it fail, and this is why the following "foo" process will continue.
pmrowla
reviewed
May 10, 2022
2 tasks
pmrowla
approved these changes
May 13, 2022
Contributor
|
Looks good, just squash or cleanup your commits to get rid of the "review fix" type messages and we can merge this |
fix: treeverse#7587 1. Add implement kill method for local queue class 2. Add a test to make sure the following job will be success after the original job was killed. 3. Some refactoring work on `exp remove`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #7587
original job was killed.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏