logger: use lazy formatting #7961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmojaki
commented
Jul 2, 2022
alexmojaki
commented
Jul 2, 2022
dvc/repo/experiments/push.py
Outdated
|
|
||
| refspec_list = [f"{exp_ref}:{exp_ref}" for exp_ref in refs] | ||
| logger.debug(f"git push experiment '{refs}' -> '{git_remote}'") | ||
| logger.debug("git push experiment %r -> '%s'", refspec_list, git_remote) |
Contributor
Author
There was a problem hiding this comment.
Here I've changed refs to refspec_list to match pull.py just above.
…ogs, especially in windows paths
efiop
reviewed
Jul 4, 2022
|
|
||
| def _log_missing(self, status: "CompareStatusResult"): | ||
| if status.missing: | ||
| if status.missing and logger.isEnabledFor(logging.WARNING): |
Contributor
There was a problem hiding this comment.
hm, could you explain the reasoning behind this change, please? Seems unrelated to the rest.
Contributor
Author
There was a problem hiding this comment.
There's a logger.warning in the block, and the costly part of the message formatting can't simply be converted to %s.
Contributor
There was a problem hiding this comment.
@alexmojaki That seems unnecessary though. I'll adjust it back for now
efiop
added
refactoring
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1843
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.