exp run: account for repo root when staging git-deps #8119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmrowla
added
A: experiments
pmrowla
commented
Aug 10, 2022
dvc/repo/reproduce.py
Outdated
| not dep.use_scm_ignore | ||
| and dep.is_in_repo | ||
| and not stage.repo.dvcfs.isdvc(dep.fs_path) | ||
| and not stage.repo.dvcfs.isdvc(str(dep)) |
Contributor
Author
There was a problem hiding this comment.
Note that we don't use dep.def_path since it's relative the stage wdir. dep.__str__ gives us path relative to the DVC repo root.
Contributor
There was a problem hiding this comment.
Probably out of the scope of the fix, but feels a little odd to have (and rely on) this logic under a representation method
pmrowla
force-pushed
the
8113-exp-git-deps
branch
from
96393af to
e247a61
Compare
pmrowla
force-pushed
the
8113-exp-git-deps
branch
from
e247a61 to
c686eb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
Fixes #8113