Solve the unexpected error at the end of the queued tasks running #8640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 94.17% // Head: 94.17% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #8640 +/- ##
==========================================
- Coverage 94.17% 94.17% -0.01%
==========================================
Files 435 435
Lines 33298 33298
Branches 4677 4677
==========================================
- Hits 31358 31357 -1
- Misses 1512 1513 +1
Partials 428 428
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
pmrowla
approved these changes
Nov 29, 2022
fix: treeverse#8615 1. This is because, at the end of the tasks, the temp running directly will be deleted 1. Only fetch result during running (not during the result collection) 2. Bump into scmrepo 0.1.4 in which we wrapped `KeyError` into `SCMError`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #8615
This is because, at the end of the tasks, the temp running directly will be deleted
Only fetch result during running (not during the result collection)
Bump into scmrepo 0.1.4 in which we wrapped
KeyErrorintoSCMError.❗ I have followed the Contributing to DVC checklist.
📖 If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏