Skip to content

Conversation

@dtrifiro
Copy link
Contributor

@dtrifiro dtrifiro commented Dec 29, 2022

This will show the cause of clone errors. e.g.

dvc get https://github.com/dberenbaum/example-get-started-cp.git README.md -o deleteme

ERROR: failed to get 'README.md' - SCM error: Failed to clone repo 'https://github.com/dberenbaum/example-get-started-cp.git' to '/tmp/tmp98x3h8g0dvc-clone': No valid credentials provided

related: #8654

@dtrifiro dtrifiro requested a review from dberenbaum December 29, 2022 14:46
@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Base: 93.51% // Head: 93.50% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (3175369) compared to base (68b2430).
Patch coverage: 33.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8746      +/-   ##
==========================================
- Coverage   93.51%   93.50%   -0.02%     
==========================================
  Files         457      457              
  Lines       36195    36203       +8     
  Branches     5242     5244       +2     
==========================================
+ Hits        33848    33850       +2     
- Misses       1839     1845       +6     
  Partials      508      508              
Impacted Files Coverage Δ
dvc/commands/get.py 86.36% <25.00%> (-6.14%) ⬇️
dvc/commands/imp.py 82.35% <25.00%> (-7.65%) ⬇️
dvc/scm.py 86.61% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dtrifiro dtrifiro added the ui user interface / interaction label Dec 29, 2022
Copy link
Contributor

@dberenbaum dberenbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good improvement.

@dtrifiro
Copy link
Contributor Author

Looking into the benchmark failures before merging...

@dtrifiro dtrifiro force-pushed the improve-clone-error-message branch from 5f5c354 to 3175369 Compare December 29, 2022 18:53
@dtrifiro dtrifiro enabled auto-merge (rebase) December 29, 2022 19:04
@dtrifiro dtrifiro merged commit 9e6f44b into treeverse:main Dec 29, 2022
@dtrifiro dtrifiro deleted the improve-clone-error-message branch December 29, 2022 19:27
@dtrifiro
Copy link
Contributor Author

Related: treeverse/scmrepo#159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui user interface / interaction

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants