Skip to content

exp: push/pull: don't include baseline commit #9164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2023
Merged

exp: push/pull: don't include baseline commit #9164

merged 1 commit into from
Mar 14, 2023

Conversation

@efiop
Copy link
Contributor

@efiop efiop commented Mar 13, 2023 •
edited
Loading

Fixes #6592

@efiop efiop changed the title exp: push/pull: don't include baseline commit [WIP] exp: push/pull: don't include baseline commit Mar 13, 2023
@efiop efiop added the A: experiments Related to dvc exp label Mar 13, 2023
@efiop efiop force-pushed the fix-6592 branch 2 times, most recently from ea0a3db to 3466f59 Compare March 14, 2023 00:54
@codecov
Copy link

codecov bot commented Mar 14, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (54a6709) 92.91% compared to head (bd8b1ae) 92.91%.

Additional details and impacted files 
@@           Coverage Diff            @@
##             main    #9164    +/-   ##
========================================
  Coverage   92.91%   92.91%            
========================================
  Files         456      456            
  Lines       36864    36860     -4     
  Branches     5320     5219   -101     
========================================
- Hits        34253    34250     -3     
  Misses       2087     2087            
+ Partials      524      523     -1
Impacted Files Coverage Δ
dvc/repo/experiments/utils.py 82.65% <ø> (+0.37%) ⬆️
tests/unit/scm/test_scm.py 100.00% <ø> (ø)
tests/func/test_gc.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@efiop efiop changed the title [WIP] exp: push/pull: don't include baseline commit exp: push/pull: don't include baseline commit Mar 14, 2023
@efiop efiop requested a review from pmrowla March 14, 2023 10:03
@efiop efiop marked this pull request as ready for review March 14, 2023 10:03
@efiop efiop merged commit b56f6b6 into treeverse:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pmrowla pmrowla pmrowla approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A: experiments Related to dvc exp

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

exp push/pull: don't include baseline commit

2 participants

@efiop @pmrowla