Skip to content

Conversation

@skshetry
Copy link
Collaborator

@skshetry skshetry commented May 22, 2023

Part of #7093.

@skshetry skshetry requested review from daavoo and dberenbaum May 22, 2023 05:48
@skshetry skshetry added breaking-change A: plots Related to the plots labels May 22, 2023
@skshetry skshetry added this to the 3.0 milestone May 22, 2023
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e089ee0) 91.41% compared to head (714e77b) 91.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9486   +/-   ##
=======================================
  Coverage   91.41%   91.42%           
=======================================
  Files         479      479           
  Lines       37360    37396   +36     
  Branches     5373     5375    +2     
=======================================
+ Hits        34152    34188   +36     
  Misses       2641     2641           
  Partials      567      567           
Impacted Files Coverage Δ
dvc/schema.py 100.00% <ø> (ø)
dvc/repo/plots/__init__.py 91.78% <100.00%> (-0.06%) ⬇️
tests/func/plots/test_show.py 100.00% <100.00%> (ø)
tests/func/test_dvcfile.py 100.00% <100.00%> (ø)
tests/integration/plots/conftest.py 100.00% <100.00%> (ø)
tests/integration/plots/test_repo_plots_api.py 100.00% <100.00%> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@daavoo daavoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skshetry
Copy link
Collaborator Author

Let's remember to update https://github.com/iterative/dvcyaml-schema

yeah, will create an issue for now.

@skshetry skshetry merged commit 6532258 into treeverse:main May 22, 2023
@skshetry skshetry deleted the drop-dict-plots-top-level branch May 22, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: plots Related to the plots breaking-change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants