-
Notifications
You must be signed in to change notification settings - Fork 39
get rid of DvcLiveError calls #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
daavoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @zili55 !
I have some doubts regarding the addition of CannotCreateLogDirError but they are not strictly related with this changes because the same doubts apply to the previous DvcLiveError
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
==========================================
+ Coverage 89.28% 90.00% +0.71%
==========================================
Files 12 12
Lines 308 310 +2
==========================================
+ Hits 275 279 +4
+ Misses 33 31 -2
Continue to review full report at Codecov.
|
Co-authored-by: David de la Iglesia Castro <daviddelaiglesiacastro@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edited.
- Remove CannotCreateLogDirError
- P.R. to
dvc.orgupdating https://dvc.org/doc/dvclive/api-reference/log#exceptions
daavoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zili55 ! Could you address:
|
@daavoo P.R. to dvc.org created: treeverse/dvc.org#2707 and maybe from here https://dvc.org/doc/dvclive/api-reference/init#exceptions we should remove that exception |
Nice
Indeed, could you add that change in the same P.R.? |
β I have followed the Contributing to DVCLive guide.
π If this PR requires documentation updates, I have created a separate PR (or issue, at least) in dvc.org and linked it here.
Thank you for the contribution - we'll try to review it as soon as possible. π