Skip to content

Conversation

@dberenbaum
Copy link

DVCLiveLogger(report=None) was throwing an error.

@dberenbaum dberenbaum requested a review from daavoo November 28, 2022 20:23
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2022

Codecov Report

Base: 96.47% // Head: 96.49% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (16da9c5) compared to base (9f9c31b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #369      +/-   ##
==========================================
+ Coverage   96.47%   96.49%   +0.01%     
==========================================
  Files          36       36              
  Lines        1789     1796       +7     
  Branches      155      155              
==========================================
+ Hits         1726     1733       +7     
  Misses         37       37              
  Partials       26       26              
Impacted Files Coverage Δ
src/dvclive/lightning.py 90.90% <100.00%> (ø)
tests/test_lightning.py 96.42% <100.00%> (+0.32%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daavoo daavoo merged commit bdcc095 into main Nov 28, 2022
@daavoo daavoo deleted the lightning-report branch November 28, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants