Skip to content

Conversation

@daavoo
Copy link
Contributor

@daavoo daavoo commented Mar 28, 2023

Ensures the images work without CORS errors and inside Colab Notebooks.

I think the motivations for not using base64 in DVC were related to VSCode integration and they don't really apply here.

Ensures the images work without CORS errors and inside Colab Notebooks.
@daavoo daavoo requested a review from dberenbaum March 28, 2023 09:20
@daavoo daavoo self-assigned this Mar 28, 2023
@daavoo daavoo added A: report Area: `live.make_report` A: log_image Area: `live.log_image` enhancement labels Mar 28, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (40fe282) 95.70% compared to head (e38fbd5) 95.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
- Coverage   95.70%   95.68%   -0.02%     
==========================================
  Files          41       41              
  Lines        2582     2573       -9     
  Branches      218      219       +1     
==========================================
- Hits         2471     2462       -9     
  Misses         66       66              
  Partials       45       45              
Impacted Files Coverage Δ
tests/test_main.py 100.00% <ø> (ø)
src/dvclive/dvc.py 93.10% <100.00%> (-0.45%) ⬇️
src/dvclive/live.py 91.61% <100.00%> (+0.14%) ⬆️
src/dvclive/report.py 93.75% <100.00%> (+0.27%) ⬆️
tests/test_dvc.py 100.00% <100.00%> (ø)
tests/test_frameworks/test_lightning.py 97.82% <100.00%> (ø)
tests/test_report.py 100.00% <100.00%> (ø)
tests/test_studio.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daavoo daavoo merged commit d511161 into main Mar 30, 2023
@daavoo daavoo deleted the report-base64-images branch March 30, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A: log_image Area: `live.log_image` A: report Area: `live.make_report` enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants