-
Notifications
You must be signed in to change notification settings - Fork 39
Support path to an image in log_image
#518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #518 +/- ##
==========================================
+ Coverage 95.74% 95.77% +0.03%
==========================================
Files 41 41
Lines 2606 2630 +24
Branches 223 225 +2
==========================================
+ Hits 2495 2519 +24
Misses 66 66
Partials 45 45
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
daavoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments about restructuring. I could do those myself in a follow-up
|
@daavoo I'll do those changes. Thanks for the review 🙏 |
15953da to
311a124
Compare
|
@daavoo @dberenbaum I've addressed the review comments and created a doc update treeverse/dvc.org#4463 |
|
@daavoo can I do a release? |
sure |
|
@daavoo do you draft them manually? |
Yes. https://github.com/iterative/dvclive/releases/new -> create a new version tag -> |
Log image from an existing file. Helps to convert a repo like YOLO where images are produced already by some core code and we need to capture and transfer them into the DVCLive output dir.
It also adds some test for
log_image.Related: https://github.com/shcheklein/ultralytics
Related: ultralytics/ultralytics#1909
Docs treeverse/dvc.org#4463
Thank you for the contribution - we'll try to review it as soon as possible. 🙏