Skip to content

Conversation

@shcheklein
Copy link
Contributor

@shcheklein shcheklein commented Apr 9, 2023

Log image from an existing file. Helps to convert a repo like YOLO where images are produced already by some core code and we need to capture and transfer them into the DVCLive output dir.

It also adds some test for log_image.

Related: https://github.com/shcheklein/ultralytics
Related: ultralytics/ultralytics#1909

Docs treeverse/dvc.org#4463


Thank you for the contribution - we'll try to review it as soon as possible. 🙏

@shcheklein shcheklein self-assigned this Apr 9, 2023
@shcheklein shcheklein requested review from daavoo and dberenbaum April 9, 2023 03:55
@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2023

Codecov Report

Patch coverage: 96.15% and project coverage change: +0.03 🎉

Comparison is base (1cb31aa) 95.74% compared to head (311a124) 95.77%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
+ Coverage   95.74%   95.77%   +0.03%     
==========================================
  Files          41       41              
  Lines        2606     2630      +24     
  Branches      223      225       +2     
==========================================
+ Hits         2495     2519      +24     
  Misses         66       66              
  Partials       45       45              
Impacted Files Coverage Δ
src/dvclive/plots/image.py 92.00% <66.66%> (+0.69%) ⬆️
src/dvclive/live.py 91.88% <100.00%> (+0.07%) ⬆️
tests/plots/test_image.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@daavoo daavoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments about restructuring. I could do those myself in a follow-up

@shcheklein
Copy link
Contributor Author

@daavoo I'll do those changes. Thanks for the review 🙏

@shcheklein
Copy link
Contributor Author

@daavoo @dberenbaum I've addressed the review comments and created a doc update treeverse/dvc.org#4463

@shcheklein shcheklein merged commit 7fe67f8 into main Apr 11, 2023
@shcheklein shcheklein deleted the log-image-from-path branch April 11, 2023 20:00
@shcheklein
Copy link
Contributor Author

@daavoo can I do a release?

@daavoo
Copy link
Contributor

daavoo commented Apr 11, 2023

@daavoo can I do a release?

sure

@shcheklein
Copy link
Contributor Author

@daavoo do you draft them manually?

@daavoo
Copy link
Contributor

daavoo commented Apr 11, 2023

@daavoo do you draft them manually?

Yes. https://github.com/iterative/dvclive/releases/new -> create a new version tag -> Generate release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants