studio: Save experiment before posting done event.
#529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure `experiment_rev` is sent.
daavoo
commented
Apr 14, 2023
|
|
||
| self._ensure_paths_are_tracked_in_dvc_exp() | ||
|
|
||
| self.save_dvc_exp() |
Contributor
Author
There was a problem hiding this comment.
I am on a streak of this kind of bugfixes
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
==========================================
+ Coverage 95.81% 95.85% +0.03%
==========================================
Files 41 41
Lines 2628 2629 +1
Branches 221 221
==========================================
+ Hits 2518 2520 +2
+ Misses 67 66 -1
Partials 43 43
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
dberenbaum
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure
experiment_revis sent.Found that it was the underlying issue of https://github.com/iterative/studio/issues/5673#issuecomment-1508480082. I thought Studio relied on
baseline_sha,exp_namepair to match live experiments with experiment ref.Regardless, this was a plain bug that had to be fixed and went under the radar.