Merged
Conversation
itaigilo
added
exclude-changelog
itaigilo
commented
Mar 24, 2025
E2E Test Results - DynamoDB Local - Local Block Adapter
|
E2E Test Results - Quickstart |
| } | ||
|
|
||
| await validateRow("Repository name", QUICKSTART_REPO_NAME); | ||
| await validateRow("Storage namespace"); |
Contributor
There was a problem hiding this comment.
Why not have some sort of validation(strict, loose) on all 3 text box values?
nadavsteindler
suggested changes
Mar 25, 2025
Contributor
nadavsteindler
left a comment
nadavsteindler
left a comment
There was a problem hiding this comment.
I had a couple questions/suggestions. If it's a problem let me know
itaigilo
commented
Mar 25, 2025
Contributor
Author
itaigilo
left a comment
itaigilo
left a comment
There was a problem hiding this comment.
Thanks @nadavsteindler for the review.
Fixed your comments, PTAL again.
| await expect(rowText).toBeVisible(); | ||
| const valueInput = rowText.locator('..').getByRole("textbox"); | ||
| await expect(valueInput).toBeVisible(); | ||
| if (inputValue) { |
Contributor
There was a problem hiding this comment.
do you still need this if?
Contributor
Author
There was a problem hiding this comment.
Yes, for using in another repo 🙏
nadavsteindler
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding some more E2E tests,
For the "Settings" tab of the Repository page.