Support multiple resources policies PART 2 #8907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merging master
ItamarYuran
added
the
include-changelog
ItamarYuran
changed the title
E2E Test Results - Quickstart |
E2E Test Results - DynamoDB Local - Local Block Adapter |
Isan-Rivkin
requested changes
Apr 1, 2025
pkg/api/controller_test.go
Outdated
| expected: auth.CheckAllow, | ||
| }, | ||
| { | ||
| name: "read second resource, unpermitted", |
Contributor
There was a problem hiding this comment.
nit
Suggested change
| name: "read second resource, unpermitted", | |
| name: "read second resource, denied", |
| } | ||
| } | ||
|
|
||
| func TestCheckPermissions_multipleResources(t *testing.T) { |
Contributor
There was a problem hiding this comment.
Please add test with 2 policies: one for allow and one for deny and make sure the deny takes effect
Contributor
Author
There was a problem hiding this comment.
Added. also added tests to prevent "["this","case",]"
Isan-Rivkin
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8857 (second part, see first part)
This PR leverages the parser func introduced in the first PR, to parse the
resourcestring and allow multiple resources statements.