Skip to content

fix missing error mapping in controller for auth #9057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nopcoder merged 2 commits into from
May 13, 2025
Merged

fix missing error mapping in controller for auth #9057

nopcoder merged 2 commits into from
May 13, 2025

Conversation

@nopcoder
Copy link
Contributor

@nopcoder nopcoder commented May 13, 2025

Map missing error to bad request - on auth.ErrInvalidRequest we should return 400 BadRequest and not 500.

@nopcoder nopcoder self-assigned this May 13, 2025
@nopcoder nopcoder added the area/API Improvements or additions to the API label May 13, 2025
@nopcoder nopcoder requested a review from N-o-Z May 13, 2025 21:19
@nopcoder nopcoder added exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached labels May 13, 2025
N-o-Z
N-o-Z approved these changes May 13, 2025
View reviewed changes
Copy link
Member

@N-o-Z N-o-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@N-o-Z
Copy link
Member

N-o-Z commented May 13, 2025

@nopcoder potentially we should write a small test for it

@github-actions
Copy link

github-actions bot commented May 13, 2025

E2E Test Results - DynamoDB Local - Local Block Adapter

13 passed, 1 skipped

@github-actions
Copy link

github-actions bot commented May 13, 2025

E2E Test Results - Quickstart

12 passed

@nopcoder
Copy link
Contributor Author

nopcoder commented May 13, 2025

@nopcoder potentially we should write a small test for it

added policy validation tests in a different PR - thanks!

@nopcoder nopcoder enabled auto-merge (squash) May 13, 2025 21:54
@nopcoder nopcoder merged commit 776d073 into master May 13, 2025
42 of 45 checks passed
@nopcoder nopcoder deleted the fix/controller-err branch May 13, 2025 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@N-o-Z N-o-Z N-o-Z approved these changes

Assignees

@nopcoder nopcoder

Labels

area/API Improvements or additions to the API exclude-changelog PR description should not be included in next release changelog minor-change Used for PRs that don't require issue attached

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nopcoder @N-o-Z