Add Capabilities Property In Config #9876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/API
Annaseli
added
the
include-changelog
N-o-Z
approved these changes
Dec 22, 2025
| Capabilities: | ||
| type: object | ||
| properties: | ||
| async_ops: |
Member
There was a problem hiding this comment.
Suggested change
| async_ops: | |
| async_ops: | |
| description: is async operations enabled in server. *EXPERIMENTAL* |
pkg/api/controller.go
Outdated
| } | ||
| } | ||
|
|
||
| func (c *Controller) getCapabilities() *apigen.Capabilities { |
pkg/api/controller.go
Outdated
|
|
||
| func (c *Controller) getCapabilities() *apigen.Capabilities { | ||
| capabilitiesConfig := c.Config.CapabilitiesConfig() | ||
| asyncOps := capabilitiesConfig.GetAsyncOps() |
itaiad200
reviewed
Dec 22, 2025
api/swagger.yml
Outdated
| $ref: "#/components/schemas/StorageConfigList" | ||
| ui_config: | ||
| $ref: "#/components/schemas/UIConfig" | ||
| capabilities: |
Contributor
There was a problem hiding this comment.
How do you feel about calling this graveler_capabilities? It feels less like 1 catches all but still general
Member
There was a problem hiding this comment.
What's graveler in the context of the controller. Controller is not suppose to be away of graveler - that's why we have catalog. I'm strongly against that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9875
Added the capabilities property In config for lakectl with async commit and merge