add check_ref_format abstract method #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrifiro
force-pushed
the
add-check-ref-format
branch
from
7690922 to
8233483
Compare
dtrifiro
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
==========================================
+ Coverage 81.66% 81.69% +0.02%
==========================================
Files 25 25
Lines 3404 3408 +4
Branches 588 589 +1
==========================================
+ Hits 2780 2784 +4
Misses 542 542
Partials 82 82 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dtrifiro
force-pushed
the
add-check-ref-format
branch
from
a0a87a4 to
67d318a
Compare
efiop
reviewed
Jan 11, 2023
Comment on lines
+393
to
+395
| @abstractmethod | ||
| def check_ref_format(self, refname: str) -> bool: | ||
| """Check if a reference name is well formed.""" |
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
There was a problem hiding this comment.
Added some context in the original message
Contributor
There was a problem hiding this comment.
Oh, didn't know that one even exists. Good to know, thank you!
efiop
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds dummy implementation for
pygit2andgitpythonIn some cases, switching backends (from dulwich) would result in
AttributeNotFoundErrordue to missing implementation inpygit2andgitpython.